khronos: backport EGLuint64KHR typedef from recent Khronos #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agherzan
pushed a commit
to agherzan/meta-raspberrypi
that referenced
this pull request
May 14, 2018
…ge_dma_buf_import The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi/userland#467> Signed-off-by: Hugo Hromic <hhromic@gmail.com>
The newer `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h>
|
@popcornmix @6by9 This looks fairly benign to me, any thoughts on merging? |
|
My concern is that then people expect it to work.
What does it use it for? Has anyone sanity checked that it will never go through the code path that is going to use a potentially undefined and unsupported type? Checking the GStreamer repos, they've already patched it. https://github.com/GStreamer/gst-plugins-base/blob/master/gst-libs/gst/gl/egl/gsteglimage.c#L89 |
|
Hi, @6by9 , thanks for pointing to the upstream fix. When I submitted this PR, that fix wasn't in order yet. |
|
I'd be inclined to close. The gstreamer change doesn't quite seem the appropriate fix, but taking this PR now will probably cause more grief than help. |
|
there are other apps e.g. weston also expecting this define |
|
looks like this PR should be resurrected and a proper solution, i.e. update Khronos?, be discussed. |
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Nov 21, 2018
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Nov 30, 2018
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Dec 15, 2018
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Jan 9, 2019
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Feb 5, 2019
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
Yes, we do check if the DMABuf extensions are provided by the stack before using it in GStreamer. It's a distro implementation, so we try and have as much as possible built-in and enabled bits at run-time. One can explicitly out-compile it when building for the pre-mesa RPi GL stack of course. |
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
May 22, 2019
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Jul 26, 2019
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Sep 14, 2019
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Nov 30, 2019
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Dec 13, 2019
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Mar 31, 2020
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Jul 13, 2020
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Jul 29, 2020
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Sep 29, 2020
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Nov 25, 2020
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Dec 2, 2020
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Feb 3, 2021
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Mar 31, 2021
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Jul 30, 2021
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Apr 3, 2022
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Nov 15, 2022
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
kraj
pushed a commit
to kraj/userland
that referenced
this pull request
Sep 7, 2023
The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi#467> Upstream-Status: Submitted
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
…pedef for EGL_EXT_image_dma_buf_import The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi/userland#467> Signed-off-by: Hugo Hromic <hhromic@gmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
…pedef for EGL_EXT_image_dma_buf_import The `gstreamer1.0-plugins-base` package version `1.14` uses `EGL_EXT_image_dma_buf_import`, which expects the `EGLuint64KHR` typedef that is present in recent versions of Khronos. However, the older version included in userland does not provide it. This patch backports the missing typedef from recent Khronos into userland. See: <https://www.khronos.org/registry/EGL/api/EGL/eglext.h> Submitted to userland in <raspberrypi/userland#467> Signed-off-by: Hugo Hromic <hhromic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer
gstreamer1.0-plugins-basepackage version1.14usesEGL_EXT_image_dma_buf_import,which expects the
EGLuint64KHRtypedef that is present in recent versions of Khronos.However, the older version included in userland does not provide it.
This patch backports the missing typedef from recent Khronos into userland.
See: https://www.khronos.org/registry/EGL/api/EGL/eglext.h